Re: [PATCH 1/9] builtin-verify-tag.c: use parse_options()
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Jul 24, 2008, 17:08 UTC
- Message-ID
- <alpine.DEB.1.00.0807241807550.8986@racer>
- In-Reply-To
- <4888B4E3.9000504@free.fr>
Hi,
On Thu, 24 Jul 2008, Olivier Marin wrote:
Show 11 quoted lines
> Michele Ballabio a écrit : > > > > if (argc == 1) > > - usage(builtin_verify_tag_usage); > > + usage_with_options(builtin_verify_tag_usage, options); > > It seems this is broken since the C rewrite: "git verify-tag -v" just do > nothing instead of printing usage message. > > Moving the if() after parse_options() call with s/argc == 1/argc == 0/ > should do the trick.
That would be a bugfix. As such, it belongs into a different commit. Care to provide a patch?
Show 5 quoted lines
> > - if (!strcmp(argv[i], "-v") || !strcmp(argv[i], "--verbose")) {
> > - verbose = 1;
> > - i++;
> > - }
> > + argc = parse_options(argc, argv, options, builtin_verify_tag_usage, 0);Why did you quote this?
Ciao, Dscho