git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Add help.autocorrect to enable/disable autocorrecting

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Jul 23, 2008, 19:04 UTC
Message-ID
<alpine.DEB.1.00.0807232003420.8986@racer>
In-Reply-To
<alpine.DEB.1.00.0807231958210.8986@racer>
Hi,
On Wed, 23 Jul 2008, Johannes Schindelin wrote:
Show 14 quoted lines
> On Wed, 23 Jul 2008, Alex Riesen wrote:
> 
> > Johannes Schindelin, Wed, Jul 23, 2008 18:44:49 +0200:
> > > > +	n = 1;
> > > > +	while (n < main_cmds.cnt &&
> > > > +		best_similarity == similarity(main_cmds.names[n]->name))
> > > > +		++n;
> > > 
> > > Mini-nit: you never ask for the value of n, only if it is 1 or larger.  So 
> > > you do not need to count...
> > 
> > But I do, don't I? AFAICS, I use 0, 1 and >1 (this-these).
> 
> Yes.  So check cnt > 0 && best_similarity > 5 says if it is 0,

Oh, I just realized that my patch is bogus anyway. It only checks for best_similarity > 5 in the case that the first two commands have equal similarity. D'oh.

Ciao, Dscho

Previous: Johannes SchindelinNext: Junio C Hamano
Message 14 of 20 in “git wrapper: DWIM mistyped commands”
  1. git wrapper: DWIM mistyped commandsJohannes Schindelin, Jul 22, 2008
  2. [SCNR] Re: [FYI PATCH] git wrapper: DWIM mistyped commandsPierre Habouzit, Jul 22, 2008
  3. Johannes SchindelinJul 22, 2008
  4. Pierre HabouzitJul 22, 2008
  5. Alex RiesenJul 22, 2008
  6. Add help.autocorrect to enable/disable autocorrectingAlex Riesen, Jul 22, 2008
  7. Johannes SchindelinJul 22, 2008
  8. Add help.autocorrect to enable/disable autocorrectingAlex Riesen, Jul 22, 2008
  9. Johannes SchindelinJul 22, 2008
  10. Add help.autocorrect to enable/disable autocorrectingAlex Riesen, Jul 22, 2008
  11. Johannes SchindelinJul 23, 2008
  12. Alex RiesenJul 23, 2008
  13. Johannes SchindelinJul 23, 2008
  14. Johannes SchindelinJul 23, 2008
  15. Junio C HamanoJul 22, 2008
  16. Wait help.autocorrect deciseconds before running corrected commandAlex Riesen, Jul 23, 2008
  17. Johannes SchindelinJul 23, 2008
  18. Alex RiesenJul 23, 2008
  19. Junio C HamanoJul 22, 2008
  20. Sverre RabbelierJul 22, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.