Re: [PATCH] Add help.autocorrect to enable/disable autocorrecting

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jul 22, 2008, 21:44 UTC
Message-ID: <alpine.DEB.1.00.0807222242160.8986@racer>
In-Reply-To: <20080722212633.GF5113@blimp.local>

Hi,

On Tue, 22 Jul 2008, Alex Riesen wrote:

Show 13 quoted lines

> @@ -704,9 +707,10 @@ const char *help_unknown_cmd(const char *cmd)
>  
>  	if (!main_cmds.cnt)
>  		die ("Uh oh.  Your system reports no Git commands at all.");
> +	git_config(git_help_config, NULL);
>  	best_similarity = similarity(main_cmds.names[0]->name);
> -	if (main_cmds.cnt < 2 || best_similarity <
> -			similarity(main_cmds.names[1]->name)) {
> +	if (autocorrect && (main_cmds.cnt < 2 ||
> +		best_similarity < similarity(main_cmds.names[1]->name))) {
>  		if (!*cwd)
>  			exit(1);
>  		if (chdir(cwd))

This "if" already checks if there is only one candidate. So you should just add an inner "if (autocorrect) ... else single = 1;" or some such.

However, I think that the intention of this patch is too much DWIMery, which might be good for me (just like my "git add remote" patch), but not for the general audience.

Ciao, Dscho