Re: [RFC PATCH] Support copy and rename detection in fast-export.

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jul 21, 2008, 10:17 UTC
Message-ID: <alpine.DEB.1.00.0807211207470.3305@eeepc-johanness>
In-Reply-To: <200807211216.01694.angavrilov@gmail.com>

Hi,

On Mon, 21 Jul 2008, Alexander Gavrilov wrote:

Show 6 quoted lines

> Although it does not matter for Git itself, tools that
> export to systems that explicitly track copies and
> renames can benefit from such information.
> 
> This patch makes fast-export output correct action
> logs when -M or -C are enabled.

I like it.

Show 7 quoted lines

> 	I'm thinking about Git->SVN conversion, like 
> 	http://repo.or.cz/w/git2svn.git
> 
> 	The trouble with this patch is that old versions of fast-export
> 	accept -M and -C, but produce garbage if they are specified.
> 	So the only way for the users to ensure that it is supported is
> 	to check the git version (or directly test it).

Unfortunately, this is so.

> 	As a somewhat related question, in which order does fast-export 
> 	output the commits, beside topological? In particular, does it order 
> 	commits on parrallel branches (i.e. not topologically dependent) by 
> 	date?

AFAIR it obeys topological order first, and then date order, by default. This can be changed by --topo-order.

But before you go and try to support more options with fast-export: Some options do not make sense, such as --reverse, "a...b", --skip, etc.

I do not even think we need to bother about die()ing with such options: the user should know what she is doing with fast-export.

Ciao, Dscho