Re: [PATCH v2] Support copy and rename detection in fast-export.

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 30, 2008, 18:35 UTC
Message-ID: <7vvdyn5ifc.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <bb6f213e0807300210r205846b4qffa9fc71d4aa6533@mail.gmail.com>

"Alexander Gavrilov" <angavrilov@gmail.com> writes:

Show 9 quoted lines

>> If you see a copied or renamed entry, you emit "this old path to that old
>> path" first, and then say that same path got modified.  It appears from my
>> quick glance of fast-import that touching the same path more than once in
>> a same commit like this sequence does would work fine (it will involve two
>> calls to tree_content_set() for the same path but that is not something it
>> has to forbid, and the function doesn't).
>
> I'm sorry, but I don't quite understand what are you suggesting by
> this paragraph.

Sorry for the unmarked remark --- this was not a question, suggestion nor complaint, but just a plain observation. I should have ended the paragraph with "--- I think it's all good." to avoid confusion.

Show 13 quoted lines

>>> +export GIT_AUTHOR_NAME='A U Thor'
>>> +export GIT_COMMITTER_NAME='C O Mitter'
>>> +
>>> +test_expect_success 'setup copies' '
>>> +
>>> +     git config --unset i18n.commitencoding &&
>>
>> These are somewhat unusual.  Was there any reason for these exports and
>> config?
>>
>
> t9301-fast-export.sh earlier changes these parameters to test
> automatic conversion to utf8.

Yeah, I noticed that while looking at wider context, after I sent the message you are responding to.

Anyway, thanks for the patch.  Applied and pushed out.