git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] Ensure that SSH runs in non-interactive mode

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Jul 21, 2008, 01:15 UTC
Message-ID
<alpine.DEB.1.00.0807210310330.3305@eeepc-johanness>
In-Reply-To
<1216598432-18553-1-git-send-email-fredrik@dolda2000.com>
Hi,
On Mon, 21 Jul 2008, Fredrik Tolf wrote:
> I'm following my previous SSH patch up with this one, which should at
> least solve the problems discussed, and probably some more. If anything,
> it might be considered a bit overkill for the problem at hand.

I am not assuming it is overkill, but since you do not reuse functions such as strbuf_expand() and split_cmdline(), your patch ends up pretty large.

And since you use very short and undescriptive variable names, with ugly assignments inside arithmetic expressions, I will be less likely reviewing it in detail.

> I assume it might have to be documented as well, if people approve of it.

Catch 22. Since you have not documented what %P should be useful for, people might not approve of the patch, because they do not understand what it is supposed to do.

People like me, Dscho

Previous: Fredrik TolfNext: Fredrik Tolf
Message 2 of 8 in “Ensure that SSH runs in non-interactive mode”
  1. Ensure that SSH runs in non-interactive modeFredrik Tolf, Jul 21, 2008
  2. Johannes SchindelinJul 21, 2008
  3. Fredrik TolfJul 21, 2008
  4. Jakub NarebskiJul 21, 2008
  5. Johannes SchindelinJul 21, 2008
  6. Jeff KingJul 21, 2008
  7. Johannes SchindelinJul 21, 2008
  8. Fredrik TolfJul 21, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.