From: Johannes Schindelin Date: Mon, 21 Jul 2008 01:15:52 GMT Subject: Re: [PATCH v2] Ensure that SSH runs in non-interactive mode Message-ID: In-Reply-To: <1216598432-18553-1-git-send-email-fredrik@dolda2000.com> Hi, On Mon, 21 Jul 2008, Fredrik Tolf wrote: > I'm following my previous SSH patch up with this one, which should at > least solve the problems discussed, and probably some more. If anything, > it might be considered a bit overkill for the problem at hand. I am not assuming it is overkill, but since you do not reuse functions such as strbuf_expand() and split_cmdline(), your patch ends up pretty large. And since you use very short and undescriptive variable names, with ugly assignments inside arithmetic expressions, I will be less likely reviewing it in detail. > I assume it might have to be documented as well, if people approve of it. Catch 22. Since you have not documented what %P should be useful for, people might not approve of the patch, because they do not understand what it is supposed to do. People like me, Dscho