git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-submodule - register module url if adding in place

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Jul 9, 2008, 00:11 UTC
Message-ID
<alpine.DEB.1.00.0807090210080.5277@eeepc-johanness>
In-Reply-To
<4873FF6E.2020602@gmail.com>
Hi,
On Tue, 8 Jul 2008, Mark Levedahl wrote:
Show 16 quoted lines
> Johannes Schindelin wrote:
> > I agree with Sylvain here, namely that this is too dangerous.  
> > Imagine this very valid scenario:
> >
> >  $ git clone <somewhere> abc
> >  $ git submodule add abc
> >
> > Bummer.
> >
> > Yes, happened to me.
> >
> > So I'd like this to be an error, not something that tries to be 
> > helpful, when it clearly cannot be.
>
> I think the real issue here is that submodule-add is too flexible and 
> poorly documented, see my response to Junio in the other thread.

In contrast, I think that we should either disallow the form without URL, or get the URL automatically from the submodule's current branch's default remote.

Ciao, Dscho

Previous: Mark Levedahl
Message 4 of 4 in “git-submodule - register module url if adding in place”
  1. git-submodule - register module url if adding in placeMark Levedahl, Jul 8, 2008
  2. Johannes SchindelinJul 8, 2008
  3. Mark LevedahlJul 8, 2008
  4. Johannes SchindelinJul 9, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.