From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Wed, 09 Jul 2008 00:11:16 GMT
Subject: Re: [PATCH] git-submodule - register module url if adding in place
Message-ID: <alpine.DEB.1.00.0807090210080.5277@eeepc-johanness>
In-Reply-To: <4873FF6E.2020602@gmail.com>

Hi,

On Tue, 8 Jul 2008, Mark Levedahl wrote:

> Johannes Schindelin wrote:
> > I agree with Sylvain here, namely that this is too dangerous.  
> > Imagine this very valid scenario:
> >
> >  $ git clone <somewhere> abc
> >  $ git submodule add abc
> >
> > Bummer.
> >
> > Yes, happened to me.
> >
> > So I'd like this to be an error, not something that tries to be 
> > helpful, when it clearly cannot be.
>
> I think the real issue here is that submodule-add is too flexible and 
> poorly documented, see my response to Junio in the other thread.

In contrast, I think that we should either disallow the form without URL, 
or get the URL automatically from the submodule's current branch's default 
remote.

Ciao,
Dscho