git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/6] revisions: refactor init_revisions and setup_revisions.

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Jul 8, 2008, 11:43 UTC
Message-ID
<alpine.DEB.1.00.0807081339270.4319@eeepc-johanness>
In-Reply-To
<20080708110624.GF19202@artemis.madism.org>
Hi,
On Tue, 8 Jul 2008, Pierre Habouzit wrote:
Show 12 quoted lines
> On Tue, Jul 08, 2008 at 10:59:43AM +0000, Johannes Schindelin wrote:
> 
> > On Tue, 8 Jul 2008, Pierre Habouzit wrote:
> > 
> > > setup_revisions has been split in two: parse_revisions that does 
> > > (almost) only argument parsing, to be more like what parse-options 
> > > can do, and setup_revisions that does the rest.
> > 
> > I do not see the sense of this change, except
> 
> Well, it's required to remove "parse_revisions" at once if we one day 
> reach the goal of having only parse-opt based parsers.
We can do that, then.
We do not need to do that, now.

In the meantime, your patch series of already pretty large patches gets even larger, which prevents me from being able to review them.

Sad, Dscho

P.S.: Please do not pull things at me like "it is so convenient to be able to drop "0, NULL, " for many sites". That is not even funny. This case does not need more convenience. The other cases do.

Previous: Pierre HabouzitNext: Pierre Habouzit
Message 13 of 15 in “Migration of builtin-blame to parse-option”
  1. Pierre HabouzitJul 8, 2008
  2. 1/6 revisions: refactor init_revisions and setup_revisions.Pierre Habouzit, Jul 8, 2008
  3. 2/6 revisions: split the pure option parsing out from parse_revisions.Pierre Habouzit, Jul 8, 2008
  4. 3/6 revisions: parse_revisions refactor.Pierre Habouzit, Jul 8, 2008
  5. 4/6 revisions: split handle_revision_args from parse_revisions.Pierre Habouzit, Jul 8, 2008
  6. 5/6 git-blame: migrate to incremental parse-option [1/2]Pierre Habouzit, Jul 8, 2008
  7. 6/6 git-blame: migrate to incremental parse-option [2/2]Pierre Habouzit, Jul 8, 2008
  8. Johannes SixtJul 8, 2008
  9. Pierre HabouzitJul 8, 2008
  10. Pierre HabouzitJul 8, 2008
  11. Johannes SchindelinJul 8, 2008
  12. Pierre HabouzitJul 8, 2008
  13. Johannes SchindelinJul 8, 2008
  14. Pierre HabouzitJul 8, 2008
  15. Pierre HabouzitJul 8, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.