Re: [PATCH 2/6] revisions: split the pure option parsing out from parse_revisions.
On Tue, Jul 08, 2008 at 10:51:13AM +0000, Johannes Sixt wrote:
Show 15 quoted lines
> Pierre Habouzit schrieb:
> > +int handle_revision_opt(struct rev_info *revs, int argc, const char **argv,
> > + int *unkc, const char **unkv)
> > +{
> > + const char *arg = argv[0];
> > +
> > + /* pseudo revision arguments */
> > + if (!strcmp(arg, "--all") || !strcmp(arg, "--branches") ||
> > + !strcmp(arg, "--tags") || !strcmp(arg, "--remotes") ||
> > + !strcmp(arg, "--reflog") || !strcmp(arg, "--not") ||
> > + !strcmp(arg, "--no-walk") || !strcmp(arg, "--do-walk"))
> > + {
> > + unkv[*unkc++] = arg;
>
> + unkv[(*unkc)++] = arg; Huh right. Good catch, I wonder why the testsuite failed to see that.
Anyways I pushed a fix on my public repo.
--
·O· Pierre Habouzit
··O madcoder@debian.org
OOO http://www.madism.org