Re: [PATCH, next version] git bisect: introduce 'fixed' and 'unfixed'

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jun 28, 2008, 13:48 UTC
Message-ID: <alpine.DEB.1.00.0806281446260.9925@racer>
In-Reply-To: <7vprq2o4zb.fsf@gitster.siamese.dyndns.org>

Hi,

On Fri, 27 Jun 2008, Junio C Hamano wrote:

Show 8 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > When you look for a fix instead of a regression, it can be quite hard 
> > to twist your brain into choosing the correct bisect command between 
> > 'git bisect bad' and 'git bisect good'.
> 
> Hmm, I do not currently see any differene between master and next version
> of bisect.  In what way is this 'next' version?

It has a "BAD" and a "GOOD" variable that are reset to "fixed" and "unfixed" if the user said "fixed" or "unfixed".

> Aside from the 'visualize' issue this does not attempt to address,

Yes, I forgot about that issue, mainly because I do not use it myself...

> I wonder if it may be a good idea to detect and warn mixed usage as well 
> (e.g. "You earlier said 'bad' but now you are saying 'fixed' -- are you 
> sure?"), and if so if it can be implemented easily.

Hmm. I tried to avoid that, as it would mean a larger patch. But I guess you could write .git/BISECT_TERMS or some such.

But that, together with the visualize part, would take more time than I am willing to spend on this issue.

Well, I guess I'll leave it then, Dscho