Re: [NON-TOY PATCH] git bisect: introduce 'fixed' and 'unfixed'
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Jun 24, 2008, 19:26 UTC
- Message-ID
- <alpine.DEB.1.00.0806242026441.9925@racer>
- In-Reply-To
- <alpine.LNX.1.00.0806241516440.19665@iabervon.org>
Hi,
On Tue, 24 Jun 2008, Daniel Barkalow wrote:
Show 20 quoted lines
> On Tue, 24 Jun 2008, Jeff King wrote: > > > On Tue, Jun 24, 2008 at 06:09:28PM +0100, Johannes Schindelin wrote: > > > > > And this is my first attempt at a proper patch for it. > > > > > > Now with documentation, and hopefully all places where the > > > user is being told about a "bad" commit. > > > > This looks reasonably sane to me. The only thing I can think of that > > we're missing is that "git bisect visualize" will still show the refs as > > "bisect/bad" and "bisect/good". > > > > To fix that, you'd have to ask people to start the bisect by saying "I > > am bisecting to find a fix, not a breakage." And then you could change > > the refnames and all of the messages as appropriate. > > That would also be a good way of taking care of the problem where someone > gets distracted while running a slow test, forgets what they're looking > for, and marks the result as "bad" instead of "unfixed".
Feel free to rework my patch.
Ciao, Dscho