Re: [PATCH] cat-file --batch / --batch-check: do not exit if hashes are missing
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Jun 8, 2008, 23:34 UTC
- Message-ID
- <alpine.DEB.1.00.0806090033030.1783@racer>
- In-Reply-To
- <1212967717-5165-1-git-send-email-LeWiemann@gmail.com>
Hi,
maybe s/do not exit/complain/? Because it still exits if the hashes are missing...
Show 15 quoted lines
> diff --git a/builtin-cat-file.c b/builtin-cat-file.c
> index f8b3160..112b9db 100644
> --- a/builtin-cat-file.c
> +++ b/builtin-cat-file.c
> @@ -168,8 +168,11 @@ static int batch_one_object(const char *obj_name, int print_contents)
> else
> type = sha1_object_info(sha1, &size);
>
> - if (type <= 0)
> - return 1;
> + if (type <= 0) {
> + printf("%s missing\n", obj_name);
> + fflush(stdout);
> + return 0;
> + }Is it really intended that it returns 0 now?
Further, should it not be an error("%s missin... instead? It is an error, isn't it?
Ciao, Dscho