git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] cat-file --batch / --batch-check: do not exit if hashes are missing

From
LWLea Wiemann <lewiemann@gmail.com>
Date
Jun 9, 2008, 13:27 UTC
Message-ID
<484D2FBA.1010606@gmail.com>
In-Reply-To
<m3lk1ex3s6.fsf@localhost.localdomain>
Jakub Narebski wrote:
> I think the (usual) solution is to add --ignore-missing and
> --no-ignore-missing (or --noignore-missing), add configuration
> option 'catfile.ignoreMissing', make ignore-missing default and
> deprecate it with some transition time...

*shrugs* I'm not convinced that anyone would ever *not* want to use --ignore-missing, since programs that use --batch(-check) presumably query for a large batch of objects and therefore define their own error handling anyway. Also, it's not like you could accidentally ignore the "<object> missing" output in your code since you're parsing the output anyway. So I'm not sure what the point of changing the current behavior is. (Perhaps add a --exit-on-missing option? Not that I or anyone else has ever asked for that feature.)

In any case, can please someone review my patch? I think my patch should be independent of these things (since it's a bug fix), and I'd hate to see it not make it into the code just because some people don't seem to like cat-file's behavior. ;-) (I need it for the Perl API, after all.)

-- Lea
Previous: Jakub NarebskiNext: Lea Wiemann
Message 7 of 12 in “cat-file --batch / --batch-check: do not exit if hashes are missing”
  1. cat-file --batch / --batch-check: do not exit if hashes are missingLea Wiemann, Jun 8, 2008
  2. Johannes SchindelinJun 8, 2008
  3. Lea WiemannJun 9, 2008
  4. Johannes SchindelinJun 9, 2008
  5. Lea WiemannJun 9, 2008
  6. Jakub NarebskiJun 9, 2008
  7. Lea WiemannJun 9, 2008
  8. cat-file --batch / --batch-check: do not exit if hashes are missingLea Wiemann, Jun 9, 2008
  9. Junio C HamanoJun 9, 2008
  10. Junio C HamanoJun 9, 2008
  11. Johannes SixtJun 9, 2008
  12. Lea WiemannJun 9, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.