Re: [PATCH v3 2/2] git-add: introduce --edit (to edit the diff vs. the index)

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jun 6, 2008, 14:21 UTC
Message-ID: <alpine.DEB.1.00.0806061514510.1783@racer>
In-Reply-To: <48490B3A.4020900@free.fr>

Hi,

On Fri, 6 Jun 2008, Olivier Marin wrote:

Show 15 quoted lines

> Johannes Schindelin a écrit :
> > 
> > +int edit_patch(int argc, const char **argv, const char *prefix)
> > +{
> 
> [...]
> 
> > +	if (!result)
> > +		result = run_command(&child);
> > +	free(child.argv);
> > +
> > +	launch_editor(file, NULL, NULL);
> 
> Here, it does not launch the editor I defined with core.editor because 
> you call edit_patch() before calling git_config() in cmd_add().

Will fix.

> Also, wouldn't be better to have the edit_patch stuff in 
> add--interactive instead ? It seems to work the same way than the 
> --patch option.

Actually, no. It does something completely different. For example, it avoids calling a perl script. At least as long as your editor is not a Perl script.

Ciao, Dscho