Re: [PATCH v2 1/2] Allow git-apply to ignore the hunk headers
- From
Paolo Bonzini <bonzini@gnu.org>
- Date
- Jun 6, 2008, 07:02 UTC
- Message-ID
- <4848E105.7050405@gnu.org>
- In-Reply-To
- <alpine.DEB.1.00.0806060030160.21190@racer>
Show 5 quoted lines
> @@ -0,0 +0,0 @@ > default: > - return -1; > + return len != 4 && memcmp(line - len, "-- \n", len); > }
You're never returning -1 here, right?
> However, this will not work if anybody has a signature starting with > "@@ ", "+", " ", "-" or "diff "...
I think that the main worry is the patches made with git-format-patch, and those are not problematic.
Paolo