git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Adding a cache of commit to patch-id pairs to speed up git-cherry

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Jun 2, 2008, 18:22 UTC
Message-ID
<alpine.DEB.1.00.0806021918590.13507@racer.site.net>
In-Reply-To
<7f9d599f0806021023r64affb36ne491792a962d455c@mail.gmail.com>
Hi,
On Mon, 2 Jun 2008, Geoffrey Irving wrote:
Show 8 quoted lines
> On Mon, Jun 2, 2008 at 7:50 AM, Geoffrey Irving <irving@naml.us> wrote:
>
> I'll switch to mmapping.
> 
> The git_mmap function in compat/mmap.c dies if NO_MMAP is defined and 
> the map isn't MAP_PRIVATE.  If I want to write an entry, will the memory 
> be automatically updated if I write directly to the file descriptor (I 
> haven't used mmap before)?

I think that you should only mmap() with MAP_PRIVATE, because you can corrupt the data easily when a write failure is not handled properly.

So I'd suggest mmap() for reading, and writing to a locked file (I think you did that already).

Ciao, Dscho

Previous: Geoffrey Irving
Message 16 of 16 in “Adding a cache of commit to patch-id pairs to speed up git-cherry”
  1. Adding a cache of commit to patch-id pairs to speed up git-cherryGeoffrey Irving, Jun 2, 2008
  2. Johannes SchindelinJun 2, 2008
  3. Jeff KingJun 2, 2008
  4. Geoffrey IrvingJun 2, 2008
  5. Johannes SchindelinJun 2, 2008
  6. Geoffrey IrvingJun 2, 2008
  7. Shawn O. PearceJun 2, 2008
  8. Johannes SchindelinJun 2, 2008
  9. Geoffrey IrvingJun 2, 2008
  10. Johannes SchindelinJun 2, 2008
  11. Geoffrey IrvingJun 7, 2008
  12. Johannes SchindelinJun 8, 2008
  13. Geoffrey IrvingJun 2, 2008
  14. Johannes SchindelinJun 2, 2008
  15. Geoffrey IrvingJun 2, 2008
  16. Johannes SchindelinJun 2, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.