Re: [PATCH] Adding a cache of commit to patch-id pairs to speed up git-cherry
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Jun 2, 2008, 16:18 UTC
- Message-ID
- <alpine.DEB.1.00.0806021717130.13507@racer.site.net>
- In-Reply-To
- <7f9d599f0806020849g567461b2kecd65dbd35d3dc3b@mail.gmail.com>
Hi,
On Mon, 2 Jun 2008, Geoffrey Irving wrote:
Show 11 quoted lines
> On Mon, Jun 2, 2008 at 8:37 AM, Johannes Schindelin > <Johannes.Schindelin@gmx.de> wrote: > > > Another issue that just hit me: this cache is append-only, so if it > > grows too large, you have no other option than to scratch and recreate > > it. Maybe this needs porcelain support, too? (git gc?) > > If so, the correct operation is to go through the hash and remove > entries that refer to commits that no longer exist. I can add this if > you want. Hopefully somewhere along the way git-gc constructs an easy > to traverse list of extant commits, and this will be straightforward.
I don't know... if you have created a cached patch-id for every commit (by mistake, for example) and do not need it anymore, it might make git-cherry substantially faster to just scrap the cache.
Hrm, Dscho