Re: [PATCH v3] Add support for GIT_CEILING_DIRS

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: May 15, 2008, 20:34 UTC
Message-ID: <alpine.DEB.1.00.0805152131390.30431@racer>
In-Reply-To: <7vej83gxjm.fsf@gitster.siamese.dyndns.org>

Hi,

On Thu, 15 May 2008, Junio C Hamano wrote:

Show 12 quoted lines

> David Reiss <dreiss@facebook.com> writes:
> 
> > + * ....  Paths must
> > + * be in a canonical form: empty components, or "." or ".." components
> > + * are not allowed.  prefix_list may be null, which is like "".
> 
> The caller starts from cwd[] and chomps, so you can safely assume that 
> it would not feed anything problematic.  But prefix_list comes from 
> user's environment, and it is easy to make mistakes like doubled slashes 
> (which you seem to take care) and also is tempting to use ".." when 
> specifying the ceiling (e.g. "CEIL=$HOME/..").  Perhaps canonicalizing 
> the ceiling would make this easier to use for end users?

Is this not going too far? I mean, CEILING_DIRECTORIES is already a very special case.

> How well would this colon separated list work with msys folks?

Not well at all. At least for the moment, I think setting this variable would fail (since it would be rewritten into a Windows-PATH-style string). Though honestly, I have no idea what getcwd() does on MinGW.

Steffen is working on that rewriting stuff, so maybe it will be a non-issue, eventually.

Ciao, Dscho