Re: [PATCH v3] Add support for GIT_CEILING_DIRS

From: Johannes Sixt <j.sixt@viscovery.net>
Date: May 16, 2008, 07:03 UTC
Message-ID: <482D31B8.8000707@viscovery.net>
In-Reply-To: <alpine.DEB.1.00.0805152131390.30431@racer>

Johannes Schindelin schrieb:

Show 8 quoted lines

> On Thu, 15 May 2008, Junio C Hamano wrote:
> 
>> David Reiss <dreiss@facebook.com> writes:
>> How well would this colon separated list work with msys folks?
> 
> Not well at all.  At least for the moment, I think setting this variable 
> would fail (since it would be rewritten into a Windows-PATH-style string).  
> Though honestly, I have no idea what getcwd() does on MinGW.

We would have to use ';' instead of ':' in longest_prefix(). Then it will work automatically. Except that it does not ignore case in path names and drive letters. Hence, the user must set this environment variable to the precise path name(s).

> Steffen is working on that rewriting stuff, so maybe it will be a 
> non-issue, eventually.

This will not matter. When we change the code to use is_path_separator() instead of hard-coded c == ':', then it will work automatically. We do that already for GIT_ALTERNATE_OBJECT_DIRECTORIES.

-- Hannes