Re: [PATCH 1/2 v2] cvsexportcommit: chomp only removes trailing whitespace
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- May 15, 2008, 03:21 UTC
- Message-ID
- <alpine.DEB.1.00.0805150421000.30431@racer>
- In-Reply-To
- <7vk5hwi9o4.fsf@gitster.siamese.dyndns.org>
Hi,
On Wed, 14 May 2008, Junio C Hamano wrote:
Show 11 quoted lines
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>
> > @@ -210,7 +210,7 @@ if (@canstatusfiles) {
> > my $basename = basename($name);
> >
> > $basename = "no file " . $basename if (exists($added{$basename}));
> > - chomp($basename);
> > + $basename =~ s/^\s+(.*?)\s*$/$1/;
>
> Isn't this no-op for a basename that does not begin with a whitespace?
> Don't you want to still strip trailing whitespaces in such a case?D'oh. Time for bed.
Ciao, Dscho