Re: [PATCH 1/2] cvsexportcommit: chomp only removes trailing whitespace

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: May 14, 2008, 22:15 UTC
Message-ID: <alpine.DEB.1.00.0805142313280.30431@racer>
In-Reply-To: <200805142206.53242.robin.rosenberg@dewire.com>

Hi,

On Wed, 14 May 2008, Robin Rosenberg wrote:

> > Yes, that is the idea.  The point is: there are at least two different 
> > implementations of cvs, and I do not want to rely on a particular one.
> 
> Does CVSNT add extra spaces?

Probably.  At least a CR I would expect.

> A question arises. Can we use cvs update instead? It can be used to 
> retrieve the latest version (as the -u flag to cvsexportcommit does) and 
> it will tell you what status each affected file has. cvs update -n will 
> just give us the status with unambigous file names.

Will it? The thing is: as far as I can see, cvs is only "porcelain", i.e. the output is meant for users' consumption, not scripts'.

So I wanted to be safe, and strip all leading and trailing whitespace, call "cvs status" (if necessary, in several runs, so that no ambiguous file names can be returned).

Ciao, Dscho