git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] Provide git_config with a callback-data parameter

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
May 15, 2008, 01:02 UTC
Message-ID
<alpine.DEB.1.00.0805150156230.30431@racer>
In-Reply-To
<7vk5hwn0tp.fsf@gitster.siamese.dyndns.org>
Hi,
On Wed, 14 May 2008, Junio C Hamano wrote:
Show 12 quoted lines
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > git_config() only had a function parameter, but no callback data
> > parameter.  This assumes that all callback functions only modify
> > global variables.
> >
> > With this patch, every callback gets a void * parameter, and it is hoped
> > that this will help the libification effort.
> 
> Great, as this has also been a pet-peeve of mine for quite some time.
> 
> Except the patch has quite a many rejects X-<.

Did you try to apply it to "next"? I thought I based it on "next"... I will prepare three patches tomorrow: for "next", "master" and "maint" respectively (even if I think that "maint" should not take it; it is no real fix).

Ciao, Dscho

Previous: Junio C HamanoNext: Junio C Hamano
Message 5 of 6 in “Fix two pet peeves of mine”
  1. 0/2 Fix two pet peeves of mineJohannes Schindelin, May 14, 2008
  2. 1/2 Rename path_list to string_listJohannes Schindelin, May 14, 2008
  3. 2/2 Provide git_config with a callback-data parameterJohannes Schindelin, May 14, 2008
  4. Junio C HamanoMay 14, 2008
  5. Johannes SchindelinMay 15, 2008
  6. Junio C HamanoMay 15, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.