From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Thu, 15 May 2008 01:02:45 GMT
Subject: Re: [PATCH 2/2] Provide git_config with a callback-data parameter
Message-ID: <alpine.DEB.1.00.0805150156230.30431@racer>
In-Reply-To: <7vk5hwn0tp.fsf@gitster.siamese.dyndns.org>

Hi,

On Wed, 14 May 2008, Junio C Hamano wrote:

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > git_config() only had a function parameter, but no callback data
> > parameter.  This assumes that all callback functions only modify
> > global variables.
> >
> > With this patch, every callback gets a void * parameter, and it is hoped
> > that this will help the libification effort.
> 
> Great, as this has also been a pet-peeve of mine for quite some time.
> 
> Except the patch has quite a many rejects X-<.

Did you try to apply it to "next"?  I thought I based it on "next"...  I 
will prepare three patches tomorrow: for "next", "master" and "maint" 
respectively (even if I think that "maint" should not take it; it is no 
real fix).

Ciao,
Dscho