git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-daemon: fix for rotating logs

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
May 11, 2008, 18:03 UTC
Message-ID
<alpine.DEB.1.00.0805111901390.30431@racer>
In-Reply-To
<alpine.DEB.1.00.0804281523040.5399@eeepc-johanness>
Hi,
On Mon, 28 Apr 2008, Johannes Schindelin wrote:
> With rotating logs, there is a problem when the syslog is opened only 
> once (in the beginning).  So open the log everytime we write something, 
> and close it directly after writing.

Actually, the culprit were _not_ rotating logs. At least not really. syslog() is not supposed to be called from a signal handler. In git-daemon, it is, from child_handler(), but only when called with --verbose (and --syslog, or --detach). Bummer.

Sorry for my wrong analysis, Dscho

Previous: Stephen R. van den Berg
Message 23 of 23 in “git-daemon: fix for rotating logs”
  1. git-daemon: fix for rotating logsJohannes Schindelin, Apr 28, 2008
  2. Junio C HamanoApr 28, 2008
  3. Johannes SchindelinApr 28, 2008
  4. Miklos VajnaApr 28, 2008
  5. Mike HommeyApr 28, 2008
  6. Johannes SchindelinApr 28, 2008
  7. Miklos VajnaApr 28, 2008
  8. Johannes SchindelinApr 28, 2008
  9. Stephen R. van den BergApr 28, 2008
  10. Johannes SchindelinApr 28, 2008
  11. Stephen R. van den BergApr 28, 2008
  12. Johannes SchindelinApr 28, 2008
  13. Stephen R. van den BergApr 28, 2008
  14. Johannes SchindelinApr 28, 2008
  15. Stephen R. van den BergApr 28, 2008
  16. Johannes SchindelinApr 28, 2008
  17. Stephen R. van den BergApr 28, 2008
  18. Andreas EricssonApr 29, 2008
  19. Johannes SchindelinApr 29, 2008
  20. Andreas EricssonApr 29, 2008
  21. Johannes SchindelinApr 29, 2008
  22. Stephen R. van den BergApr 29, 2008
  23. Johannes SchindelinMay 11, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.