git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-daemon: fix for rotating logs

From
Stephen R. van den Berg <srb@cuci.nl>
Date
Apr 28, 2008, 19:28 UTC
Message-ID
<20080428192837.GB21950@cuci.nl>
In-Reply-To
<20080428190047.GG26880@genesis.frugalware.org>
Miklos Vajna wrote:
>Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
>> > Isn't the problem that git-daemon loses its connection to the syslog 
>> > daemon when logrotate sighups syslog?
No.
>Right, but logrotate could send SIGHUP to git-daemon as well.

It could, but that's the reason one uses the openlog(3) interface to syslog, to centralise logfilemanagement and *not* having to deal with the intricacies of logfile rotation and the like. So it doesn't need to. When you need logfile rotation, you're better off with using openlog(3), and doing that the proper way means *NOT* closing and reopening that everytime.

>> I have no idea, but other programs must have the same problem.  I should

They don't. Your patch fixes the wrong problem. Please don't fix something that wasn't broken in the first place.

>> have shown some diligence and researched that.  Will do so now.
>I don't say that just one example justifies me, but here is an example:
>icald (google://openlog+sighup 2nd result) does this.

N.B. I've never had to close and reopen the openlog(3) syslog interface in any of the daemons I've written. The example you refer to of icald is where it directly writes to a logfile, which is *not* what this patch was about, so please do not use it as justification.

-- 
Sincerely,                                                          srb@cuci.nl
           Stephen R. van den Berg.
Previous: Johannes SchindelinNext: Johannes Schindelin
Message 9 of 23 in “git-daemon: fix for rotating logs”
  1. git-daemon: fix for rotating logsJohannes Schindelin, Apr 28, 2008
  2. Junio C HamanoApr 28, 2008
  3. Johannes SchindelinApr 28, 2008
  4. Miklos VajnaApr 28, 2008
  5. Mike HommeyApr 28, 2008
  6. Johannes SchindelinApr 28, 2008
  7. Miklos VajnaApr 28, 2008
  8. Johannes SchindelinApr 28, 2008
  9. Stephen R. van den BergApr 28, 2008
  10. Johannes SchindelinApr 28, 2008
  11. Stephen R. van den BergApr 28, 2008
  12. Johannes SchindelinApr 28, 2008
  13. Stephen R. van den BergApr 28, 2008
  14. Johannes SchindelinApr 28, 2008
  15. Stephen R. van den BergApr 28, 2008
  16. Johannes SchindelinApr 28, 2008
  17. Stephen R. van den BergApr 28, 2008
  18. Andreas EricssonApr 29, 2008
  19. Johannes SchindelinApr 29, 2008
  20. Andreas EricssonApr 29, 2008
  21. Johannes SchindelinApr 29, 2008
  22. Stephen R. van den BergApr 29, 2008
  23. Johannes SchindelinMay 11, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.