Re: [PATCH] gitk: make Ctrl "+" really increase the font size

From: Johannes Schindelin <johannes.schindelin-mmb7mzphnfy@public.gmane.org>
Date: Jan 14, 2008, 15:57 UTC
Message-ID: <alpine.DEB.1.00.0801141555100.23987@eeepc-johanness>
In-Reply-To: <fmft8d$kuv$2@ger.gmane.org>

Hi,

[please do not cull me from the Cc' list.  It's like answering to what I 
 said while looking at someone else.]

On Mon, 14 Jan 2008, Stephan Hennig wrote:

Show 26 quoted lines

> Johannes Schindelin schrieb:
> > 
> > Only Ctrl "=" was bound to increase the font size, probably because
> > English keyboards have the plus on the same key as the equal sign.
> > However, not the whole world is English, and at least with some
> > other keyboard layouts, Ctrl "+" did not work as documented.
> > 
> > Noticed by Stephan Hennig.
> > 
> > Signed-off-by: Johannes Schindelin <Johannes.Schindelin-Mmb7MZpHnFY@public.gmane.org>
> > 
> > ---
> > 
> > 	On Thu, 10 Jan 2008, Stephan Hennig wrote:
> > 
> > 	> 
> > 	> Hi,
> > 	> 
> > 	> reducing font size in gitk with CTRL-- works, but enlarging font 
> > 	> size fails.  Typing CTRL-+ just doesn't have any effect here.
> > 
> > 	This is no bug in msysgit, but in gitk.
> > 
> > 	Paul, please apply.
> 
> The bug is still present in gitk that comes with Msysgit

If you are complaining about msysgit, please do not flood the git list with your response.

Besides, it is asking a little much after just 4 days for a patch to come through no less than 4 different repositories: gitk -> git.git -> mingw.git -> 4msysgit.git.

A patch that you could apply yourself easily, with the further benefit of being able to added your "Tested-by:" line.

After all, I just worked for you, for free, and I expect something back.

Hth, Dscho