threads / patch / 11582

patchgitk: make Ctrl "+" really increase the font size

Subject: [PATCH] gitk: make Ctrl "+" really increase the font size

## tl;dr

7 messages between Jan 11, 2008 and Jan 15, 2008. Diffs are folded; open one to read it.

replies: 6people: 6as markdown or json

Johannes Schindelin· Jan 11, 2008, 12:39 UTC · lore

Only Ctrl "=" was bound to increase the font size, probably because English keyboards have the plus on the same key as the equal sign. However, not the whole world is English, and at least with some other keyboard layouts, Ctrl "+" did not work as documented.

Noticed by Stephan Hennig.
Signed-off-by: Johannes Schindelin <Johannes.Schindelin-Mmb7MZpHnFY@public.gmane.org>
---
	On Thu, 10 Jan 2008, Stephan Hennig wrote:
	> 
	> Hi,
	> 
	> reducing font size in gitk with CTRL-- works, but enlarging font 
	> size fails.  Typing CTRL-+ just doesn't have any effect here.
	This is no bug in msysgit, but in gitk.
	Paul, please apply.
 gitk |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Show changes to gitk +1 −0
diff --git a/gitk b/gitk
index 1da0b0a..462f6aa 100644
--- a/gitk
+++ b/gitk
@@ -996,6 +996,7 @@ proc makewindow {} {
     bind . <$M1B-r> dosearchback
     bind . <$M1B-s> dosearch
     bind . <$M1B-equal> {incrfont 1}
+    bind . <$M1B-plus> {incrfont 1}
     bind . <$M1B-KP_Add> {incrfont 1}
     bind . <$M1B-minus> {incrfont -1}
     bind . <$M1B-KP_Subtract> {incrfont -1}
Johannes Sixt· Jan 11, 2008, 12:59 UTC · re: Johannes Schindelin · lore

Re: [PATCH] gitk: make Ctrl "+" really increase the font size

Johannes Schindelin schrieb:
Show 8 quoted lines
> Only Ctrl "=" was bound to increase the font size, probably because
> English keyboards have the plus on the same key as the equal sign.
> However, not the whole world is English, and at least with some
> other keyboard layouts, Ctrl "+" did not work as documented.
> 
> Noticed by Stephan Hennig.
> 
> Signed-off-by: Johannes Schindelin <Johannes.Schindelin-Mmb7MZpHnFY@public.gmane.org>
                                                         ^^^^^^^^^^^^^^...
WTF is going on these days?
[note: yours, git ML and msysgit ML adresses corrected manually]
-- Hannes
Julio Espinoza-Sokal· Jan 11, 2008, 13:22 UTC · re: Johannes Sixt · lore

Re: [PATCH] gitk: make Ctrl "+" really increase the font size

On Jan 11, 2008 7:59 AM, Johannes Sixt <j.sixt@viscovery.net> wrote:
Show 16 quoted lines
> Johannes Schindelin schrieb:
> > Only Ctrl "=" was bound to increase the font size, probably because
> > English keyboards have the plus on the same key as the equal sign.
> > However, not the whole world is English, and at least with some
> > other keyboard layouts, Ctrl "+" did not work as documented.
> >
> > Noticed by Stephan Hennig.
> >
> > Signed-off-by: Johannes Schindelin <Johannes.Schindelin-Mmb7MZpHnFY@public.gmane.org>
>                                                          ^^^^^^^^^^^^^^...
> WTF is going on these days?
>
> [note: yours, git ML and msysgit ML adresses corrected manually]
>
> -- Hannes
>

I don't know if this is new, but it seems that's a feature of Gmane to prevent spam. http://gmane.org/tmda.php

Johannes Schindelin· Jan 11, 2008, 13:47 UTC · re: Johannes Sixt · lore

Re: [PATCH] gitk: make Ctrl "+" really increase the font size

On Fri, 11 Jan 2008, Johannes Sixt wrote:
Show 8 quoted lines
> Johannes Schindelin schrieb:
> 
> > Signed-off-by: Johannes Schindelin 
> > <Johannes.Schindelin-Mmb7MZpHnFY@public.gmane.org>
>                                                          ^^^^^^^^^^^^^^...
> WTF is going on these days?
> 
> [note: yours, git ML and msysgit ML adresses corrected manually]

Umm. The copy of my mail _I_ got via vger.kernel.org was _not_ corrupted. So I think the problem is on the viewer's side (IOW gmane), not the sender or the mailing list...

Ciao, Dscho

Stephan Hennig· Jan 14, 2008, 14:52 UTC · lore

Re: [PATCH] gitk: make Ctrl "+" really increase the font size

Johannes Schindelin schrieb:
Show 23 quoted lines
> 
> Only Ctrl "=" was bound to increase the font size, probably because
> English keyboards have the plus on the same key as the equal sign.
> However, not the whole world is English, and at least with some
> other keyboard layouts, Ctrl "+" did not work as documented.
> 
> Noticed by Stephan Hennig.
> 
> Signed-off-by: Johannes Schindelin <Johannes.Schindelin-Mmb7MZpHnFY@public.gmane.org>
> 
> ---
> 
> 	On Thu, 10 Jan 2008, Stephan Hennig wrote:
> 
> 	> 
> 	> Hi,
> 	> 
> 	> reducing font size in gitk with CTRL-- works, but enlarging font 
> 	> size fails.  Typing CTRL-+ just doesn't have any effect here.
> 
> 	This is no bug in msysgit, but in gitk.
> 
> 	Paul, please apply.
The bug is still present in gitk that comes with Msysgit
> $ git version
> git version 1.5.4.rc3.941.gebb79

Best regards, Stephan Hennig

Johannes Schindelin· Jan 14, 2008, 15:57 UTC · re: Stephan Hennig · lore

Re: [PATCH] gitk: make Ctrl "+" really increase the font size

Hi,
[please do not cull me from the Cc' list.  It's like answering to what I 
 said while looking at someone else.]
On Mon, 14 Jan 2008, Stephan Hennig wrote:
Show 26 quoted lines
> Johannes Schindelin schrieb:
> > 
> > Only Ctrl "=" was bound to increase the font size, probably because
> > English keyboards have the plus on the same key as the equal sign.
> > However, not the whole world is English, and at least with some
> > other keyboard layouts, Ctrl "+" did not work as documented.
> > 
> > Noticed by Stephan Hennig.
> > 
> > Signed-off-by: Johannes Schindelin <Johannes.Schindelin-Mmb7MZpHnFY@public.gmane.org>
> > 
> > ---
> > 
> > 	On Thu, 10 Jan 2008, Stephan Hennig wrote:
> > 
> > 	> 
> > 	> Hi,
> > 	> 
> > 	> reducing font size in gitk with CTRL-- works, but enlarging font 
> > 	> size fails.  Typing CTRL-+ just doesn't have any effect here.
> > 
> > 	This is no bug in msysgit, but in gitk.
> > 
> > 	Paul, please apply.
> 
> The bug is still present in gitk that comes with Msysgit

If you are complaining about msysgit, please do not flood the git list with your response.

Besides, it is asking a little much after just 4 days for a patch to come through no less than 4 different repositories: gitk -> git.git -> mingw.git -> 4msysgit.git.

A patch that you could apply yourself easily, with the further benefit of being able to added your "Tested-by:" line.

After all, I just worked for you, for free, and I expect something back.

Hth, Dscho

Stephan Hennig· Jan 15, 2008, 13:50 UTC · re: Johannes Schindelin · lore

Re: [PATCH] gitk: make Ctrl "+" really increase the font size

Johannes Schindelin schrieb:
Show 8 quoted lines
>> > 	This is no bug in msysgit, but in gitk.
>> > 
>> > 	Paul, please apply.
>> 
>> The bug is still present in gitk that comes with Msysgit
> 
> If you are complaining about msysgit, please do not flood the git list 
> with your response.

You've pointed me to the git list, but since I actually made my observations with Msysgit I kept that list copied.

> Besides, it is asking a little much after just 4 days for a patch to come 
> through no less than 4 different repositories: gitk -> git.git -> 
> mingw.git -> 4msysgit.git.

I didn't know that. Since I couldn't find an entry in the list of changes for Git 1.5.4 RC3 and both Git and Msysgit are labelled as RCs I though instant feedback was the right thing. Sorry for inconveniencing you.

> A patch that you could apply yourself easily, with the further benefit of 
> being able to added your "Tested-by:" line.
> 
> After all, I just worked for you, for free, and I expect something back.

Thanks! Actually, I think reporting bugs already is giving something (feedback) to the community. Since an application has the chance to be distributed with one less bug, user's acceptance is probably a little bit higher.

Giving something to you - feel free to use one of the LaTeX or MetaPost packages I've written, read the MetaPost manual where I'm a co-author or ask LaTeX or MetaPost related questions on some LaTeX related newsgroup or list. I'd be happy to give some assistance.

As for Git, since I don't speak Perl and I'm not fluent in C I guess I can't help much on that front.

Best regards, Stephan Hennig

← back to recent threads