Re: [PATCH 2/2] fetch-pack: accept "pack" output for packfile URIs

From: Ted Nyman <tnyman@openai.com>
Date: Jul 14, 2026, 18:38 UTC
Message-ID: <alaCQKXKcWr723Ij@com-76773>
In-Reply-To: <20260714071231.GD2516582@coredump.intra.peff.net>

> I also think this would all be much nicer with a strbuf (which would
> let us get rid of the magic numbers), but that is a slightly larger
> refactor:

Using a strbuf makes sense. One wrinkle, I think, is that with transfer.fsckobjects enabled, index-pack can emit dangling .gitmodules OIDs after the initial pack/keep line, which parse_gitmodules_oids() still needs to read from cmd.out. Would strbuf_getwholeline_fd() be a better fit here, so we don't consume those with strbuf_read()?

I'll also fix the --index-pack-args documentation while rerolling.

Thanks, Ted

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.