Re: [PATCH v5 0/3] packfile URIs: support concurrent downloads

From: Jeff King <peff@peff.net>
Date: Jul 26, 2026, 09:21 UTC
Message-ID: <20260726092153.GB3529827@coredump.intra.peff.net>
In-Reply-To: <cover.1785047139.git.tnyman@openai.com>

On Sat, Jul 25, 2026 at 11:44:45PM -0700, Ted Nyman wrote:

Show 8 quoted lines

> Changes since v4:
> 
>   * Clarify that the first --index-pack-arg specifies the command and
>     subsequent instances specify its arguments.
>   * Drop assumptions about which concurrent response reaches the
>     staging file first. Either write order exercises the same
>     overlapping-download behavior.
>   * No production code changes.

Thanks. I hadn't really reviewed the code in v4 carefully, but I did so for v5. I _think_ it is all correct, but it there are a few confusing bits in the middle patch that might be worth breaking apart for readability.

I could live with it as-is, though.

-Peff

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.