Re: [PATCH] t9811: replace 'test -f' and '! test -f' with 'test_path_*'
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Jul 7, 2026, 14:51 UTC
- Message-ID
- <ak0ShAvpvnGh1569@pks.im>
- In-Reply-To
- <CAO=vGZpMe3dxyzFVwR7BWBxaAZ-z9Kw3CqQ0kAe5ZZGSQszkzw@mail.gmail.com>
On Mon, Jul 06, 2026 at 12:00:00PM -0300, Marcelo Machado Lage wrote:
Show 28 quoted lines
> Em sex., 3 de jul. de 2026 às 05:20, Patrick Steinhardt <ps@pks.im> escreveu: > > On Thu, Jul 02, 2026 at 11:07:04AM -0300, Marcelo Machado Lage wrote: > > > diff --git a/t/t9811-git-p4-label-import.sh b/t/t9811-git-p4-label-import.sh > > > index 7614dfbd95..93d6b4c479 100755 > > > --- a/t/t9811-git-p4-label-import.sh > > > +++ b/t/t9811-git-p4-label-import.sh > > > @@ -62,9 +62,9 @@ test_expect_success 'basic p4 labels' ' > > > > > > cd main && > > > git checkout TAG_F1_ONLY && > > > - ! test -f f2 && > > > + test_path_is_missing f2 && > > > git checkout TAG_WITH\$_SHELL_CHAR && > > > - test -f f1 && test -f f2 && test -f file_with_\$metachar && > > > + test_path_is_file f1 && test_path_is_file f2 && test_path_is_file file_with_\$metachar && > > > > While at it we could split this line into three lines -- it's getting > > overly long, and we typically don't chain multiple commands on one line > > nowadays. > > We'll do this for v2 as well and make it into a patch series to > separate test interface modernization from formatting changes. > > While on this, there are some other places in the file where multiple > commands in a && chain appear in a single line, e.g. in line 244: > > p4 edit f2 && date >f2 && p4 submit -d "change" f2 && > Should we split these into multiple lines as well, even though they > are under the 80 characters limit?
Sure, if you want to convert this into a patch series anyway then I think it makes sense to adapt all such locations in this test suite.
Patrick