git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 1/2] t9811: break long && chains into multiple lines

From
MLMarcelo Machado Lage <marcelomlage@usp.br>
Date
Jul 11, 2026, 16:04 UTC
Message-ID
<20260711160447.99708-2-marcelomlage@usp.br>
In-Reply-To
<20260711160447.99708-1-marcelomlage@usp.br>
Rewrite single-line && chains by breaking them into multiple lines.
Co-authored-by: Vinicius Lira de Freitas <vinilira@usp.br>
Signed-off-by: Vinicius Lira de Freitas <vinilira@usp.br>
Signed-off-by: Marcelo Machado Lage <marcelomlage@usp.br>
---
 t/t9811-git-p4-label-import.sh | 20 +++++++++++++++-----
 1 file changed, 15 insertions(+), 5 deletions(-)
diff --git a/t/t9811-git-p4-label-import.sh b/t/t9811-git-p4-label-import.sh
index 7614dfbd95..072bc88210 100755
--- a/t/t9811-git-p4-label-import.sh
+++ b/t/t9811-git-p4-label-import.sh
@@ -64,7 +64,9 @@ test_expect_success 'basic p4 labels' '
 		git checkout TAG_F1_ONLY &&
 		! test -f f2 &&
 		git checkout TAG_WITH\$_SHELL_CHAR &&
-		test -f f1 && test -f f2 && test -f file_with_\$metachar &&
+		test -f f1 &&
+		test -f f2 &&
+		test -f file_with_\$metachar &&
 
 		git show TAG_LONG_LABEL | grep -q "A Label second line"
 	)
@@ -231,17 +233,25 @@ test_expect_success 'importing labels with missing revisions' '
 		P4CLIENT=missing-revision &&
 		client_view "//depot/missing-revision/... //missing-revision/..." &&
 		cd "$cli" &&
-		>f1 && p4 add f1 && p4 submit -d "start" &&
+		>f1 && 
+		p4 add f1 &&
+		p4 submit -d "start" &&
 
 		p4 tag -l TAG_S0 ... &&
 
-		>f2 && p4 add f2 && p4 submit -d "second" &&
+		>f2 &&
+		p4 add f2 &&
+		p4 submit -d "second" &&
 
 		startrev=$(p4_head_revision //depot/missing-revision/...) &&
 
-		>f3 && p4 add f3 && p4 submit -d "third" &&
+		>f3 &&
+		p4 add f3 &&
+		p4 submit -d "third" &&
 
-		p4 edit f2 && date >f2 && p4 submit -d "change" f2 &&
+		p4 edit f2 &&
+		date >f2 &&
+		p4 submit -d "change" f2 &&
 
 		endrev=$(p4_head_revision //depot/missing-revision/...) &&
 
-- 
2.34.1
Previous: Marcelo Machado LageNext: Marcelo Machado Lage
Message 7 of 9 in “t9811: replace 'test -f' and '! test -f' with 'test_path_*'”
  1. t9811: replace 'test -f' and '! test -f' with 'test_path_*'Marcelo Machado Lage, Jul 2, 2026
  2. Patrick SteinhardtJul 3, 2026
  3. Junio C HamanoJul 3, 2026
  4. Marcelo Machado LageJul 6, 2026
  5. Patrick SteinhardtJul 7, 2026
  6. 0/2 t9811: reformat and modernize testsMarcelo Machado Lage, Jul 11, 2026
  7. 1/2 t9811: break long && chains into multiple linesMarcelo Machado Lage, Jul 11, 2026
  8. 2/2 t9811: replace 'test -f' and '! test -f' with 'test_path_*'Marcelo Machado Lage, Jul 11, 2026
  9. Patrick SteinhardtJul 13, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.