git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC PATCH 08/10] pack-objects: introduce '--stdin-packs=follow-reachable'

From
Taylor Blau <me@ttaylorr.com>
Date
Jun 27, 2026, 02:26 UTC
Message-ID
<aj801vo5+MZ2C3Va@nand.local>
In-Reply-To
<xmqq8q8068f7.fsf@gitster.g>
On Fri, Jun 26, 2026 at 07:09:32PM -0700, Junio C Hamano wrote:
Show 15 quoted lines
> Taylor Blau <me@ttaylorr.com> writes:
>
> >> > +	if (packed_object_info(p, ofs, &oi) < 0)
> >> > +		return 0;
> >> > +	if (type != OBJ_COMMIT && type != OBJ_TAG)
> >> > +		return 0;
> >>
> >> We do not care about non commits, non tags.
> >
> > This should not be an &&, but rather an ||. We only want to handle
> > objects which are either commits *or* tags via this function.
>
> My comment above did not mean to say anything is wrong in the code;
> I was just thinking aloud.  We return for blob or tree because they
> are not commit and they are not tag. [...]

Absolutely. Sorry about that, I have no idea how I tricked myself into misreading the patch here. The second sentence of what I wrote above is correct, but not the first.

Thanks, Taylor

Previous: Junio C HamanoNext: Taylor Blau
Message 15 of 18 in “repack: combine '--geometric' and '--cruft'”
  1. 00/10 repack: combine '--geometric' and '--cruft'Taylor Blau, Jun 26, 2026
  2. 01/10 repack: unconditionally exclude non-kept packsTaylor Blau, Jun 26, 2026
  3. 03/10 repack: mark geometric progression of packs as retainedTaylor Blau, Jun 26, 2026
  4. 04/10 repack: teach MIDX retention about geometric rollupsTaylor Blau, Jun 26, 2026
  5. Junio C HamanoJun 26, 2026
  6. Taylor BlauJun 27, 2026
  7. 05/10 repack: delete geometric packs via existing_packsTaylor Blau, Jun 26, 2026
  8. 06/10 repack-geometry: drop unused redundant-pack removalTaylor Blau, Jun 26, 2026
  9. 02/10 repack: extract `locate_existing_pack()` helperTaylor Blau, Jun 26, 2026
  10. 07/10 pack-objects: extract `stdin_packs_add_all_pack_entries()`Taylor Blau, Jun 26, 2026
  11. 08/10 pack-objects: introduce '--stdin-packs=follow-reachable'Taylor Blau, Jun 26, 2026
  12. Junio C HamanoJun 26, 2026
  13. Taylor BlauJun 27, 2026
  14. Junio C HamanoJun 27, 2026
  15. Taylor BlauJun 27, 2026
  16. 09/10 pack-objects: support '--refs-snapshot' with 'follow-reachable'Taylor Blau, Jun 26, 2026
  17. 10/10 repack: support combining '--geometric' with '--cruft'Taylor Blau, Jun 26, 2026
  18. Junio C HamanoJul 27, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.