From: Taylor Blau Date: Sat, 27 Jun 2026 02:26:30 GMT Subject: Re: [RFC PATCH 08/10] pack-objects: introduce '--stdin-packs=follow-reachable' Message-ID: In-Reply-To: On Fri, Jun 26, 2026 at 07:09:32PM -0700, Junio C Hamano wrote: > Taylor Blau writes: > > >> > + if (packed_object_info(p, ofs, &oi) < 0) > >> > + return 0; > >> > + if (type != OBJ_COMMIT && type != OBJ_TAG) > >> > + return 0; > >> > >> We do not care about non commits, non tags. > > > > This should not be an &&, but rather an ||. We only want to handle > > objects which are either commits *or* tags via this function. > > My comment above did not mean to say anything is wrong in the code; > I was just thinking aloud. We return for blob or tree because they > are not commit and they are not tag. [...] Absolutely. Sorry about that, I have no idea how I tricked myself into misreading the patch here. The second sentence of what I wrote above is correct, but not the first. Thanks, Taylor