git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] builtin/init-db: deprecate alias for git-init(1)

From
Patrick Steinhardt <ps@pks.im>
Date
Jun 2, 2026, 12:34 UTC
Message-ID
<ah7N5bKAiAORtNkp@pks.im>
In-Reply-To
<xmqqv7c1xs76.fsf@gitster.g>
On Tue, Jun 02, 2026 at 05:27:41PM +0900, Junio C Hamano wrote:
Show 21 quoted lines
> Patrick Steinhardt <ps@pks.im> writes:
> 
> > I wouldn't mind that outcome much, either. What triggered this series is
> > that I'm always annoyed that it's "builtin/init-db.c" instead of
> > "builtin/init.c", and the same for `cmd_init_db()`. But I intentionally
> > constructed the series in a way that the first commit can be picked
> > as-is, so that we can adjust our code to the modern world while not
> > doing the deprecation dance.
> >
> > So I'd be equally happy if we just drop the second commit in this
> > series.
> 
> I'd actually find myself annoyed by such a rename when looking for
> builtin/init-db.c only to find it gone---much like how a previous
> rename made ll-merge difficult to locate.
> 
> My point is that while static names may annoy some, renaming them
> does not resolve the annoyance; it merely shifts it to someone else.
> 
> So, if the primary motivation is just the first patch, I would be
> less inclined to support this series.

That's entirely fair. My take on this is a bit different, as I think it's beneficial to accept a short-term adjustment for core contributors in favor of making stuff easier to discover/maintain going forward.

A new contributor would probably be quick to learn that every `cmd_foo()` entry point is named exactly the same as the subcommand name, but they will then eventually trip over the few exceptions like `cmd_init_db()` where that assumption doesn't hold.

But I can see that this is not always clear-cut.
Patrick
Previous: Junio C HamanoNext: Phillip Wood
Message 14 of 20 in “Deprecate git-init-db(1) alias”
  1. 0/2 Deprecate git-init-db(1) aliasPatrick Steinhardt, Jun 1, 2026
  2. 1/2 builtin/init-db: rename to "builtin/init.c"Patrick Steinhardt, Jun 1, 2026
  3. 2/2 builtin/init-db: deprecate alias for git-init(1)Patrick Steinhardt, Jun 1, 2026
  4. Kristoffer HaugsbakkJun 1, 2026
  5. Patrick SteinhardtJun 1, 2026
  6. Phillip WoodJun 1, 2026
  7. Patrick SteinhardtJun 1, 2026
  8. Kristoffer HaugsbakkJun 1, 2026
  9. Junio C HamanoJun 1, 2026
  10. Patrick SteinhardtJun 2, 2026
  11. Kristoffer HaugsbakkJun 2, 2026
  12. Patrick SteinhardtJun 2, 2026
  13. Junio C HamanoJun 2, 2026
  14. Patrick SteinhardtJun 2, 2026
  15. Phillip WoodJun 2, 2026
  16. Patrick SteinhardtJun 2, 2026
  17. SZEDER GáborJun 2, 2026
  18. Junio C HamanoJun 1, 2026
  19. Phillip WoodJun 2, 2026
  20. Junio C HamanoJun 2, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.