Re: [PATCH 2/2] builtin/init-db: deprecate alias for git-init(1)
- From
- Phillip Wood <phillip.wood123@gmail.com>
- Date
- Jun 1, 2026, 13:48 UTC
- Message-ID
- <042e66b5-122b-4c86-a9a9-f75f763666a7@gmail.com>
- In-Reply-To
- <ah12uk7IFxS92OR1@pks.im>
On 01/06/2026 13:10, Patrick Steinhardt wrote:
Show 18 quoted lines
> On Mon, Jun 01, 2026 at 11:31:46AM +0200, Kristoffer Haugsbakk wrote:
>> On Mon, Jun 1, 2026, at 09:56, Patrick Steinhardt wrote:
>>> diff --git a/git.c b/git.c
>>> index a72394b599..6bf6a60360 100644
>>> --- a/git.c
>>> +++ b/git.c
>>> @@ -591,7 +591,9 @@ static struct cmd_struct commands[] = {
>>> { "hook", cmd_hook, RUN_SETUP_GENTLY },
>>> { "index-pack", cmd_index_pack, RUN_SETUP_GENTLY | NO_PARSEOPT },
>>> { "init", cmd_init },
>>> +#ifndef WITH_BREAKING_CHANGES
>>> { "init-db", cmd_init },
>>
>> This can be marked as deprecated.
>>
>> { "init-db", cmd_init, DEPRECATED },
>
> Ah, indeed! Added locally now, thanks.Deprecating this command seems very sensible to me. As well as marking it deprecated, do we want to print a warning when it is run? I imagine anyone who has this command in their muscle memory is unlikely to be reading the man page on a regular basis so wont see the warning there.
Thanks
Phillip
> Patrick >