Re: [PATCH v4 00/13] pack-objects: integrate --path-walk and some --filter options
- From
Taylor Blau <me@ttaylorr.com>
- Date
- May 19, 2026, 23:53 UTC
- Message-ID
- <agz3/ZxZZHBKofR9@nand.local>
- In-Reply-To
- <pull.2101.v4.git.1778707135.gitgitgadget@gmail.com>
On Wed, May 13, 2026 at 09:18:42PM +0000, Derrick Stolee via GitGitGadget wrote:
Show 16 quoted lines
> UPDATES IN V4 > ============= > > Thanks, Taylor for the careful review. > > * Several typos are fixed. > * The performance test is corrected for issues around piping Git commands > and made more robust to the existence of submodules. > * BIG: The tree:0 patch is significantly updated in this version. Taylor > correctly smelled a problem with the new logic to emit the /tagged-trees > object set, and that signaled that those trees were previously never > emitted. I update the test to demonstrate that changing the data shape > (including tagged trees that are otherwise-unreachable) doesn't change > the test behavior, signaling a bug. The behavior change details all the > complexities of visiting only directly-requested trees under a tree:0 > filter and recursing on all trees in other cases.
Thanks for the new round; I gave this a lighter pass since I had reviewed v3 in detail and the range-diff here looks good. I focused in on a few patches in particular, and left a couple of minor comments.
My main reservation is that the "path starts with a '/' slash character when directly requested" behavior feels brittle to me, and I am not sure if there is a cleaner way to express that.
I'm curious what your thoughts are there. I think barring that things are near-complete here, though I did note one issue with the t/perf changes (that is my fault for having a bad suggestion on the earlier round).
Thanks, Taylor