Re: [PATCH v3 01/12] t5620: make test work with path-walk var
- From
Taylor Blau <me@ttaylorr.com>
- Date
- May 12, 2026, 01:03 UTC
- Message-ID
- <agJ8V4wKF6NQI0fO@nand.local>
- In-Reply-To
- <0840110116a967d39d8b63dbfe822ea9b2500088.1778523189.git.gitgitgadget@gmail.com>
On Mon, May 11, 2026 at 06:12:58PM +0000, Derrick Stolee via GitGitGadget wrote:
Show 8 quoted lines
> From: Derrick Stolee <stolee@gmail.com> > > The GIT_TEST_PACK_PATH_WALK test variable allows enabling the > --path-walk option to 'git pack-objects' by default. This sometimes > engages the warning that --path-walk is incompatible with the --filter > option. These tests in t5620 fail due to this warning over stderr in > this case. Disable this variable for this moment until these options > work together.
Makes sense. I think it would be equally OK to set this at the top-level similar to c51f5a6437c (t5326: test multi-pack bitmap behavior, 2021-08-31), but this is equally fine. Especially so if there are other tests in the script that we do want to exercise under --path-walk.
Looks good.
Thanks, Taylor