Re: [PATCH v3] generate-configlist: collapse depfile for older Ninja
- From
Patrick Steinhardt <ps@pks.im>
- Date
- May 21, 2026, 09:31 UTC
- Message-ID
- <ag7Q5_qz2MCAcdFp@pks.im>
- In-Reply-To
- <20260515-toon-fix-almalinux8-v3-1-b545a0647f0f@iotcl.com>
On Fri, May 15, 2026 at 10:42:26AM +0200, Toon Claes wrote:
Show 13 quoted lines
> diff --git a/tools/generate-configlist.sh b/tools/generate-configlist.sh
> index e28054f9e0..d1d2ba4bb7 100755
> --- a/tools/generate-configlist.sh
> +++ b/tools/generate-configlist.sh
> @@ -42,9 +42,12 @@ if test -n "$DEPFILE"
> then
> QUOTED_OUTPUT="$(printf '%s\n' "$OUTPUT" | sed 's,[&/\],\\&,g')"
> {
> + printf '%s' "$QUOTED_OUTPUT: "
> printf '%s\n' "$SOURCE_DIR"/Documentation/*config.adoc \
> "$SOURCE_DIR"/Documentation/config/*.adoc |
> - sed -e 's/[# ]/\\&/g' -e "s/^/$QUOTED_OUTPUT: /"
> + sed -e 's/[# ]/\\&/g' |The `-e` switch is now arguably not necessary anymore, but that's not a huge concern.
Show 5 quoted lines
> + tr '\n' ' ' > + printf '\n' > printf '%s:\n' "$SOURCE_DIR"/Documentation/*config.adoc \ > "$SOURCE_DIR"/Documentation/config/*.adoc | > sed -e 's/[# ]/\\&/g'
The extra printf could've been rolled into the second printf call via `printf '\n%s:\n'`, but that's not a huge concern, either.
Other than that this looks good to me, thanks!
Patrick