Re: [PATCH 2/2] connect: improve check for plink to reduce false positives
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Apr 24, 2015, 06:37 UTC
- Message-ID
- <af8ebead06428a182fcb628301f34dd9@www.dscho.org>
- In-Reply-To
- <20150423155304.GA26018@peff.net>
Hi Peff,
On 2015-04-23 17:53, Jeff King wrote:
> What about "plink-0.83" that was mentioned earlier in the thread?
I was working a lot with Java projects where the base name is often considered to be the part before a version number that is encoded into the file name, so I think it would be a good idea here, too. Essentially, it would be the regex
^(.*[/\\])?plink(-.*|\.exe)$
... and maybe we should actually do exactly this, use a regex? I know that many developers try to stay away from them, but if you can read them, they are an efficient encoding of expectations.
Ciao, Dscho