Re: [BUG] having 'plink' anywhere in the GIT_SSH environment variables sets putty = true

From: Jeff King <peff@peff.net>
Date: Apr 22, 2015, 23:23 UTC
Message-ID: <20150422232306.GA32705@peff.net>
In-Reply-To: <20150422222455.GA274681@vauxhall.crustytoothpaste.net>

On Wed, Apr 22, 2015 at 10:24:55PM +0000, brian m. carlson wrote:

Show 7 quoted lines

> On Wed, Apr 22, 2015 at 06:00:54PM -0400, Jeff King wrote:
> > Yeah, that looks right to me. You might want to represent the "are we
> > tortoise" check as a separate flag, though, and reuse it a few lines
> > later.
> 
> Sounds like a good idea.  I'll send a more formal patch a bit later
> today.

Thanks.

Show 9 quoted lines

> > Also, not related to your patch, but I notice the "putty" declaration is
> > in a different scope than I would have expected, which made me wonder if
> > it gets initialized in all code paths. I think is from the recent
> > addition of CONNECT_DIAG_URL, which pushes the bulk of the code into its
> > own else clause, even though the first part of the "if" always returns
> > early.  I wonder if it would be simpler to read like:
> [...]
> 
> I can drop this in as a preparatory patch if I can have your sign-off.

Definitely, thanks.

Signed-off-by: Jeff King <peff@peff.net>

-Peff