[PATCH] Do not chop HTML tags in commit search result

From: Jean-Baptiste Quenot <jbq@caraldi.com>
Date: Feb 13, 2008, 17:37 UTC
Message-ID: <ae63f8b50802130937mddf9df9re2a95bee44661ee3@mail.gmail.com>

Hi there,

Thanks for Git! It's a great program. I encountered an annoying bug with gitweb 1.5.4.1, when searching for commits, if the search string is too long, the generated HTML is munged leading to an ill-formed XHTML document.

Here is the patch, hope it helps:

diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index ae2d057..2c0b990 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -3780,7 +3780,10 @@ sub git_search_grep_body {
                                my $trail = esc_html($3) || "";
                                $trail = chop_str($trail, 30, 10);
                                my $text = "$lead<span
class=\"match\">$match</span>$trail";
-                               print chop_str($text, 80, 5) . "<br/>\n";
+                               # Do not chop $text as match can be
long, and we don't want to
+                               # munge HTML tags!
+                               #print chop_str($text, 80, 5) . "<br/>\n";
+                               print $text . "<br/>\n";
                        }
                }
                print "</td>\n" .

-- 
1.5.4.1-dirty