git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC/PATCH v2] gitweb: Option to chop at beginning and in the middle in chop_str

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 25, 2008, 01:46 UTC
Message-ID
<7v8x19st7x.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<20080224125920.24448.2179.stgit@localhost.localdomain>
Jakub Narebski <jnareb@gmail.com> writes:
Show 13 quoted lines
> Make use of new feature of chop_str to better cut matched string and
> its context in match info for searching commit messages (commit
> search), as proposed by Junio C Hamano.  For example, if you are
> looking for "very long ... and how" in the first paragraph of this message
> (if it were all on a single line), you would now see:
>
>     ...st this with <<very long ... and how>> the actual out...
>
> instead of:
>
>     Could som... <<very long search stri...>> the actual out...
>
> (where <<something>> denotes emphasized / colored fragment).
This part needs rewritten; the first paragraph of what message is that?

Also I think the subject is wrong. Yes, it is adding an option to an internal subroutine but who cares? The net effect the "gitweb" users see is that the way the grep result is shown differently, hopefully in a more understandable way, and that change is not _optional_ at all.

The code looks easier to read than before, but I may be partial ;-)

Previous: Jakub NarebskiNext: Jakub Narebski
Message 12 of 16 in “Do not chop HTML tags in commit search result”
  1. Do not chop HTML tags in commit search resultJean-Baptiste Quenot, Feb 13, 2008
  2. Jakub NarebskiFeb 13, 2008
  3. Junio C HamanoFeb 13, 2008
  4. gitweb: Better chopping in commit search resultsJakub Narebski, Feb 22, 2008
  5. Junio C HamanoFeb 22, 2008
  6. Jakub NarebskiFeb 22, 2008
  7. Jakub NarebskiFeb 22, 2008
  8. gitweb: Option to chop at beginning and in the middle in chop_strJakub Narebski, Feb 23, 2008
  9. Junio C HamanoFeb 23, 2008
  10. Jakub NarebskiFeb 23, 2008
  11. gitweb: Option to chop at beginning and in the middle in chop_strJakub Narebski, Feb 24, 2008
  12. Junio C HamanoFeb 25, 2008
  13. gitweb: Better cutting matched string and its contextJakub Narebski, Feb 25, 2008
  14. Junio C HamanoFeb 25, 2008
  15. Karl HasselströmFeb 23, 2008
  16. Jakub NarebskiFeb 23, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.