git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 0/8] improve "git format-patch --commit-list-format"

From
PWPhillip Wood <phillip.wood123@gmail.com>
Date
Mar 26, 2026, 14:29 UTC
Message-ID
<ad6a32f9-1b48-4bb5-97c5-96d1dfea3074@gmail.com>
In-Reply-To
<xmqqqzpa489h.fsf@gitster.g>
On 23/03/2026 20:10, Junio C Hamano wrote:
Show 35 quoted lines
> Mirko Faina <mroik@delayed.space> writes:
> 
>> Not much has changed, just applied the suggestions Kristoffer made.
>> Thank you again for the review
>>
>> [1/8] pretty.c: better die message %(count) and %(total) (Mirko Faina)
>> [2/8] format-patch: refactor generate_commit_list_cover (Mirko Faina)
>> [3/8] format-patch: rename --cover-letter-format option (Mirko Faina)
>> [4/8] docs/pretty-formats: add %(count) and %(total) (Mirko Faina)
>> [5/8] format.commitListFormat: strip meaning from empty (Mirko Faina)
>> [6/8] format-patch: wrap generate_commit_list_cover() (Mirko Faina)
>> [7/8] format-patch: add preset for --commit-list-format (Mirko Faina)
>> [8/8] format-patch: --commit-list-format without prefix (Mirko Faina)
>>
>>   Documentation/config/format.adoc    |  2 +-
>>   Documentation/git-format-patch.adoc | 19 ++++----
>>   Documentation/pretty-formats.adoc   |  4 ++
>>   builtin/log.c                       | 35 +++++++-------
>>   pretty.c                            |  4 +-
>>   t/t4014-format-patch.sh             | 72 +++++++++++++++++++----------
>>   t/t9902-completion.sh               |  1 -
>>   7 files changed, 84 insertions(+), 53 deletions(-)
> 
> All incremental changes look reasonable to me, and it seems we have
> already reached the point of diminishing returns?
> 
> It is possible that people are only commenting on low-hanging
> obvious typoes and mistakes without seeing a bigger picture,
> but I think I've read through an earlier iteration of the series,
> and found it more-or-less solid, and I do not think there was a
> drastic change of course since then, so I am happy to mark the topic
> for 'next' now.
> 
> Unless other people find bigger issues remaining in the series, that
> is, of course ;-)

I've just had a look at what you merged to next and it looks sound to me. The tweaks to the new feature in this series are very welcome improvements.

Thanks
Phillip
> Thanks.
> 
Previous: Kristoffer HaugsbakkNext: Junio C Hamano
Message 35 of 42 in “improve "git format-patch --commit-list-format"”
  1. 0/7 improve "git format-patch --commit-list-format"Mirko Faina, Mar 14, 2026
  2. 1/7 pretty.c: better die message %(count) and %(total)Mirko Faina, Mar 14, 2026
  3. 3/7 format-patch: rename --cover-letter-format optionMirko Faina, Mar 14, 2026
  4. 2/7 format-patch: refactor generate_commit_list_coverMirko Faina, Mar 14, 2026
  5. 4/7 format.commitListFormat: strip meaning from emptyMirko Faina, Mar 14, 2026
  6. 5/7 format-patch: wrap generate_commit_list_cover()Mirko Faina, Mar 14, 2026
  7. Kristoffer HaugsbakkMar 17, 2026
  8. Mirko FainaMar 17, 2026
  9. 6/7 format-patch: add preset for --commit-list-formatMirko Faina, Mar 14, 2026
  10. 7/7 format-patch: --commit-list-format without prefixMirko Faina, Mar 14, 2026
  11. Kristoffer HaugsbakkMar 17, 2026
  12. Mirko FainaMar 17, 2026
  13. 0/8 improve "git format-patch --commit-list-format"Mirko Faina, Mar 19, 2026
  14. 1/8 pretty.c: better die message %(count) and %(total)Mirko Faina, Mar 19, 2026
  15. 2/8 format-patch: refactor generate_commit_list_coverMirko Faina, Mar 19, 2026
  16. 4/8 docs/pretty-formats: add %(count) and %(total)Mirko Faina, Mar 19, 2026
  17. Kristoffer HaugsbakkMar 23, 2026
  18. Mirko FainaMar 23, 2026
  19. 3/8 format-patch: rename --cover-letter-format optionMirko Faina, Mar 19, 2026
  20. 5/8 format.commitListFormat: strip meaning from emptyMirko Faina, Mar 19, 2026
  21. 6/8 format-patch: wrap generate_commit_list_cover()Mirko Faina, Mar 19, 2026
  22. 8/8 format-patch: --commit-list-format without prefixMirko Faina, Mar 19, 2026
  23. 7/8 format-patch: add preset for --commit-list-formatMirko Faina, Mar 19, 2026
  24. 0/8 improve "git format-patch --commit-list-format"Mirko Faina, Mar 23, 2026
  25. 1/8 pretty.c: better die message %(count) and %(total)Mirko Faina, Mar 23, 2026
  26. 2/8 format-patch: refactor generate_commit_list_coverMirko Faina, Mar 23, 2026
  27. 4/8 docs/pretty-formats: add %(count) and %(total)Mirko Faina, Mar 23, 2026
  28. 3/8 format-patch: rename --cover-letter-format optionMirko Faina, Mar 23, 2026
  29. 5/8 format.commitListFormat: strip meaning from emptyMirko Faina, Mar 23, 2026
  30. 6/8 format-patch: wrap generate_commit_list_cover()Mirko Faina, Mar 23, 2026
  31. 8/8 format-patch: --commit-list-format without prefixMirko Faina, Mar 23, 2026
  32. 7/8 format-patch: add preset for --commit-list-formatMirko Faina, Mar 23, 2026
  33. Junio C HamanoMar 23, 2026
  34. Kristoffer HaugsbakkMar 24, 2026
  35. Phillip WoodMar 26, 2026
  36. Junio C HamanoMar 26, 2026
  37. Mirko FainaMar 27, 2026
  38. Junio C HamanoMar 27, 2026
  39. Mirko FainaMar 27, 2026
  40. Junio C HamanoMar 27, 2026
  41. D. Ben KnobleMar 26, 2026
  42. Mirko FainaMar 26, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.