git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 1/8] pretty.c: better die message %(count) and %(total)

From
Mirko Faina <mroik@delayed.space>
Date
Mar 19, 2026, 22:38 UTC
Message-ID
<a0d26c5999980f87b12022d12031d9f0dabbd864.1773959395.git.mroik@delayed.space>
In-Reply-To
<cover.1773959395.git.mroik@delayed.space>

Improve die messages for commands that do not support %(count) and %(total)

Signed-off-by: Mirko Faina <mroik@delayed.space>
---
 pretty.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/pretty.c b/pretty.c
index 74673714c8..814803980b 100644
--- a/pretty.c
+++ b/pretty.c
@@ -1551,7 +1551,7 @@ static size_t format_commit_one(struct strbuf *sb, /* in UTF-8 */
 
 	if (starts_with(placeholder, "(count)")) {
 		if (!c->pretty_ctx->rev)
-			die(_("this format specifier can't be used with this command"));
+			die(_("%s is not supported by this command"), "%(count)");
 		strbuf_addf(sb, "%0*d", decimal_width(c->pretty_ctx->rev->total),
 			    c->pretty_ctx->rev->nr);
 		return 7;
@@ -1559,7 +1559,7 @@ static size_t format_commit_one(struct strbuf *sb, /* in UTF-8 */
 
 	if (starts_with(placeholder, "(total)")) {
 		if (!c->pretty_ctx->rev)
-			die(_("this format specifier can't be used with this command"));
+			die(_("%s is not supported by this command"), "%(total)");
 		strbuf_addf(sb, "%d", c->pretty_ctx->rev->total);
 		return 7;
 	}
-- 
2.53.0.1018.g2bb0e51243
Previous: Mirko FainaNext: Mirko Faina
Message 14 of 42 in “improve "git format-patch --commit-list-format"”
  1. 0/7 improve "git format-patch --commit-list-format"Mirko Faina, Mar 14, 2026
  2. 1/7 pretty.c: better die message %(count) and %(total)Mirko Faina, Mar 14, 2026
  3. 3/7 format-patch: rename --cover-letter-format optionMirko Faina, Mar 14, 2026
  4. 2/7 format-patch: refactor generate_commit_list_coverMirko Faina, Mar 14, 2026
  5. 4/7 format.commitListFormat: strip meaning from emptyMirko Faina, Mar 14, 2026
  6. 5/7 format-patch: wrap generate_commit_list_cover()Mirko Faina, Mar 14, 2026
  7. Kristoffer HaugsbakkMar 17, 2026
  8. Mirko FainaMar 17, 2026
  9. 6/7 format-patch: add preset for --commit-list-formatMirko Faina, Mar 14, 2026
  10. 7/7 format-patch: --commit-list-format without prefixMirko Faina, Mar 14, 2026
  11. Kristoffer HaugsbakkMar 17, 2026
  12. Mirko FainaMar 17, 2026
  13. 0/8 improve "git format-patch --commit-list-format"Mirko Faina, Mar 19, 2026
  14. 1/8 pretty.c: better die message %(count) and %(total)Mirko Faina, Mar 19, 2026
  15. 2/8 format-patch: refactor generate_commit_list_coverMirko Faina, Mar 19, 2026
  16. 4/8 docs/pretty-formats: add %(count) and %(total)Mirko Faina, Mar 19, 2026
  17. Kristoffer HaugsbakkMar 23, 2026
  18. Mirko FainaMar 23, 2026
  19. 3/8 format-patch: rename --cover-letter-format optionMirko Faina, Mar 19, 2026
  20. 5/8 format.commitListFormat: strip meaning from emptyMirko Faina, Mar 19, 2026
  21. 6/8 format-patch: wrap generate_commit_list_cover()Mirko Faina, Mar 19, 2026
  22. 8/8 format-patch: --commit-list-format without prefixMirko Faina, Mar 19, 2026
  23. 7/8 format-patch: add preset for --commit-list-formatMirko Faina, Mar 19, 2026
  24. 0/8 improve "git format-patch --commit-list-format"Mirko Faina, Mar 23, 2026
  25. 1/8 pretty.c: better die message %(count) and %(total)Mirko Faina, Mar 23, 2026
  26. 2/8 format-patch: refactor generate_commit_list_coverMirko Faina, Mar 23, 2026
  27. 4/8 docs/pretty-formats: add %(count) and %(total)Mirko Faina, Mar 23, 2026
  28. 3/8 format-patch: rename --cover-letter-format optionMirko Faina, Mar 23, 2026
  29. 5/8 format.commitListFormat: strip meaning from emptyMirko Faina, Mar 23, 2026
  30. 6/8 format-patch: wrap generate_commit_list_cover()Mirko Faina, Mar 23, 2026
  31. 8/8 format-patch: --commit-list-format without prefixMirko Faina, Mar 23, 2026
  32. 7/8 format-patch: add preset for --commit-list-formatMirko Faina, Mar 23, 2026
  33. Junio C HamanoMar 23, 2026
  34. Kristoffer HaugsbakkMar 24, 2026
  35. Phillip WoodMar 26, 2026
  36. Junio C HamanoMar 26, 2026
  37. Mirko FainaMar 27, 2026
  38. Junio C HamanoMar 27, 2026
  39. Mirko FainaMar 27, 2026
  40. Junio C HamanoMar 27, 2026
  41. D. Ben KnobleMar 26, 2026
  42. Mirko FainaMar 26, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.