git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 0/4] curl: pass long values where expected

From
KHKristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
Date
Jun 6, 2025, 15:51 UTC
Message-ID
<ad3fccf5-be36-417c-b2a2-f2289444ac40@app.fastmail.com>
In-Reply-To
<CAN0heSqJfrLYbVmKh9-mS0fHkBSDR2dxphSaF7Q_qfyzONs2Eg@mail.gmail.com>
On Fri, Jun 6, 2025, at 17:43, Martin Ågren wrote:
Show 14 quoted lines
>> Maybe I don’t understand range-diffs enough but it looked like this was
>> using `0l` instead of `0L`.[1]  However the patches do use `<num>L` instead
>> of `<num>l` throughout.  Which I like
>>
>> † 1: Or rather I don’t understand that this is showing `0l`
>
> You can read "--" as "we no longer remove this" and "-+" as "we no
> longer add this". In fact, this whole section begins with "-" (in the
> outer diff) and we can read this as "we no longer touch this at all."
>
> Where, crucially, it's "we no longer touch this *in this patch*". Patch
> 1/4 in this v2 does change this from "0" to "0L" and this updated patch
> 4/4 then leaves this spot as is. Unlike in v1, when this was a much bigger
> patch that touched this spot and many others.
Aha, thanks!
-- 
Kristoffer Haugsbakk
Previous: Martin Ågren
Message 14 of 14 in “curl: pass `long` values where expected”
  1. curl: pass `long` values where expectedJohannes Schindelin via GitGitGadget, Jun 5, 2025
  2. Kristoffer HaugsbakkJun 5, 2025
  3. Johannes SchindelinJun 5, 2025
  4. 0/4 curl: pass long values where expectedJohannes Schindelin via GitGitGadget, Jun 6, 2025
  5. 1/4 curl: fix integer constant typechecks with curl_easy_setopt()Jeff King via GitGitGadget, Jun 6, 2025
  6. 2/4 curl: fix integer variable typechecks with curl_easy_setopt()Jeff King via GitGitGadget, Jun 6, 2025
  7. 3/4 curl: fix symbolic constant typechecks with curl_easy_setopt()Jeff King via GitGitGadget, Jun 6, 2025
  8. 4/4 curl: pass `long` values where expectedJohannes Schindelin via GitGitGadget, Jun 6, 2025
  9. Jeff KingJun 6, 2025
  10. Junio C HamanoJun 6, 2025
  11. Junio C HamanoJun 6, 2025
  12. Kristoffer HaugsbakkJun 6, 2025
  13. Martin ÅgrenJun 6, 2025
  14. Kristoffer HaugsbakkJun 6, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.