From: Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
Date: Fri, 06 Jun 2025 15:51:44 GMT
Subject: Re: [PATCH v2 0/4] curl: pass long values where expected
Message-ID: <ad3fccf5-be36-417c-b2a2-f2289444ac40@app.fastmail.com>
In-Reply-To: <CAN0heSqJfrLYbVmKh9-mS0fHkBSDR2dxphSaF7Q_qfyzONs2Eg@mail.gmail.com>

On Fri, Jun 6, 2025, at 17:43, Martin Ågren wrote:
>> Maybe I don’t understand range-diffs enough but it looked like this was
>> using `0l` instead of `0L`.[1]  However the patches do use `<num>L` instead
>> of `<num>l` throughout.  Which I like
>>
>> † 1: Or rather I don’t understand that this is showing `0l`
>
> You can read "--" as "we no longer remove this" and "-+" as "we no
> longer add this". In fact, this whole section begins with "-" (in the
> outer diff) and we can read this as "we no longer touch this at all."
>
> Where, crucially, it's "we no longer touch this *in this patch*". Patch
> 1/4 in this v2 does change this from "0" to "0L" and this updated patch
> 4/4 then leaves this spot as is. Unlike in v1, when this was a much bigger
> patch that touched this spot and many others.

Aha, thanks!

-- 
Kristoffer Haugsbakk