Re: [GSoC PATCH 11/16] t3903: avoid suppressing git's exit code

From: Tian Yuchen <a3205153416@gmail.com>
Date: Mar 29, 2026, 16:14 UTC
Message-ID: <acce32dc-b7ef-4b28-a36f-8ab90ccdc825@gmail.com>
In-Reply-To: <20260328200255.247759-12-vikingtc4@gmail.com>

On 3/29/26 04:02, Trieu Huynh wrote:

Show 30 quoted lines

> Update t3903-stash.sh to redirect git-cmds output to a temporary
> file instead of piping it directly to not hide the exit code
> of git commands behind pipes, as a crash in git might go
> unnoticed.
> 
> Signed-off-by: Trieu Huynh <vikingtc4@gmail.com>
> ---
>   t/t3903-stash.sh | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/t/t3903-stash.sh b/t/t3903-stash.sh
> index 70879941c2..b67cf23fbb 100755
> --- a/t/t3903-stash.sh
> +++ b/t/t3903-stash.sh
> @@ -962,7 +962,8 @@ test_expect_success 'store updates stash ref and reflog' '
>   	test_path_is_missing bazzy &&
>   	git stash store -m quuxery $STASH_ID &&
>   	test $(git rev-parse stash) = $STASH_ID &&
> -	git reflog --format=%H stash| grep $STASH_ID &&
> +	git reflog --format=%H stash >actual &&
> +	test_grep "$STASH_ID" actual &&
>   	git stash pop &&
>   	grep quux bazzy
>   '
> @@ -976,7 +977,7 @@ test_expect_success 'handle stash specification with spaces' '
>   	echo cow >file &&
>   	git stash &&
>   	git stash apply "stash@{$stamp}" &&
> -	grep pig file
> +	test_grep pig file

What does this have to do with the title of this patch? There is no pipe operator here, not even a single Git command. I suspect you wrote a script to generate this series of patches. The commit messages are the same for every patch.

As mentioned in the link provided by Junio, what matters in microprojects is quality, not quantity. Are these patches meaningful in and of themselves? Of course they are, but are they *necessary*? That’s a matter of opinion. What really matters is that the Git community evaluates your overall performance to determine whether you have the ability to write code according to the code guidelines, test your own work, and communicate with other developers — not how useful the patch itself is.

>   '
>   
>   test_expect_success 'setup stash with index and worktree changes' '

Keep learning, and welcome to the Git community!

Regards, Yuchen