git/list[1] front-page[2] threads[3] people[4] search[5] about
wed 2026-10-07 17:33 UTC

[GSoC PATCH 01/16] t7004: avoid suppressing git's exit code

From
Trieu Huynh <vikingtc4@gmail.com>
Date
Mar 28, 2026, 20:02 UTC
Message-ID
<20260328200255.247759-2-vikingtc4@gmail.com>
In-Reply-To
<20260328200255.247759-1-vikingtc4@gmail.com>

Update t7004-tag.sh to redirect git-cmds output to a temporary file instead of piping it directly to not hide the exit code of git commands behind pipes, as a crash in git might go unnoticed.

Signed-off-by: Trieu Huynh <vikingtc4@gmail.com>
---
 t/t7004-tag.sh | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/t/t7004-tag.sh b/t/t7004-tag.sh
index ce2ff2a28a..9bd5c98f93 100755
--- a/t/t7004-tag.sh
+++ b/t/t7004-tag.sh
@@ -1560,7 +1560,8 @@ test_expect_success 'filename for the message is relative to cwd' '
 		cd subdir &&
 		git tag -a -F msgfile-5 tag-from-subdir
 	) &&
-	git cat-file tag tag-from-subdir | grep "in sub directory"
+	git cat-file tag tag-from-subdir >actual &&
+	test_grep "in sub directory" actual
 '
 
 test_expect_success 'filename for the message is relative to cwd' '
@@ -1569,7 +1570,8 @@ test_expect_success 'filename for the message is relative to cwd' '
 		cd subdir &&
 		git tag -a -F msgfile-6 tag-from-subdir-2
 	) &&
-	git cat-file tag tag-from-subdir-2 | grep "in sub directory"
+	git cat-file tag tag-from-subdir-2 >actual &&
+	test_grep "in sub directory" actual
 '
 
 # create a few more commits to test --contains
-- 
2.43.0
Previous: Trieu HuynhNext: Trieu Huynh
Message 2 of 24 in “Microproject: avoid suppressing git's exit code”
  1. 00/16 Microproject: avoid suppressing git's exit codeTrieu Huynh, Mar 28, 2026
  2. 01/16 t7004: avoid suppressing git's exit codeTrieu Huynh, Mar 28, 2026
  3. 02/16 t6423: avoid suppressing git's exit codeTrieu Huynh, Mar 28, 2026
  4. 03/16 t6411: avoid suppressing git's exit codeTrieu Huynh, Mar 28, 2026
  5. 04/16 t6101: avoid suppressing git's exit codeTrieu Huynh, Mar 28, 2026
  6. 05/16 t6006: avoid suppressing git's exit codeTrieu Huynh, Mar 28, 2026
  7. 06/16 t5304: avoid suppressing git's exit codeTrieu Huynh, Mar 28, 2026
  8. 07/16 t4153: avoid suppressing git's exit codeTrieu Huynh, Mar 28, 2026
  9. 08/16 t4150: avoid suppressing git's exit codeTrieu Huynh, Mar 28, 2026
  10. 09/16 t4140: avoid suppressing git's exit codeTrieu Huynh, Mar 28, 2026
  11. 10/16 t4039: avoid suppressing git's exit codeTrieu Huynh, Mar 28, 2026
  12. 11/16 t3903: avoid suppressing git's exit codeTrieu Huynh, Mar 28, 2026
  13. 12/16 t3701: avoid suppressing git's exit codeTrieu Huynh, Mar 28, 2026
  14. 13/16 t3412: avoid suppressing git's exit codeTrieu Huynh, Mar 28, 2026
  15. 14/16 t1400: avoid suppressing git's exit codeTrieu Huynh, Mar 28, 2026
  16. 15/16 t0100: avoid suppressing git's exit codeTrieu Huynh, Mar 28, 2026
  17. 16/16 t2206: avoid suppressing git's exit codeTrieu Huynh, Mar 28, 2026
  18. Junio C HamanoMar 29, 2026
  19. Trieu HuynhMar 29, 2026
  20. Tian YuchenMar 29, 2026
  21. Tian YuchenMar 29, 2026
  22. Karthik NayakMar 30, 2026
  23. Junio C HamanoMar 30, 2026
  24. Trieu HuynhMar 30, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.